d87b9f68a2
- Refactor reviewPass function to identify states with review checks instead of specific review types. - Introduce review policies (HUMAN, AGENT, AUTO) to control PR review processes based on developer levels. - Update projectTick to handle review policies and step routing labels for reviewers and testers. - Add detailed reviewer instructions to templates for clarity on review responsibilities. - Implement role:level label management, allowing dynamic creation of labels based on project configuration. - Enhance task_update tool to support state and level updates, ensuring at least one parameter is provided. - Update work_finish tool to include reviewer actions (approve, reject) in task completion. - Modify work_start tool to utilize role-level detection for better level assignment. - Add tests for new functionalities, including review routing and level detection from labels.
128 lines
4.1 KiB
TypeScript
128 lines
4.1 KiB
TypeScript
/**
|
|
* queue-scan.ts — Issue queue scanning helpers.
|
|
*
|
|
* Shared by: tick (projectTick), work-start (auto-pickup), and other consumers
|
|
* that need to find queued issues or detect roles/levels from labels.
|
|
*/
|
|
import type { Issue, StateLabel } from "../providers/provider.js";
|
|
import type { IssueProvider } from "../providers/provider.js";
|
|
import { getLevelsForRole, getAllLevels } from "../roles/index.js";
|
|
import {
|
|
getQueueLabels,
|
|
getAllQueueLabels,
|
|
detectRoleFromLabel as workflowDetectRole,
|
|
type WorkflowConfig,
|
|
type Role,
|
|
} from "../workflow.js";
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Label detection
|
|
// ---------------------------------------------------------------------------
|
|
|
|
export function detectLevelFromLabels(labels: string[]): string | null {
|
|
const lower = labels.map((l) => l.toLowerCase());
|
|
|
|
// Priority 1: Match role:level labels (e.g., "developer:senior", "tester:junior")
|
|
for (const l of lower) {
|
|
const colon = l.indexOf(":");
|
|
if (colon === -1) continue;
|
|
const level = l.slice(colon + 1);
|
|
const all = getAllLevels();
|
|
if (all.includes(level)) return level;
|
|
}
|
|
|
|
// Priority 2: Match legacy role.level labels (e.g., "dev.senior", "qa.mid")
|
|
for (const l of lower) {
|
|
const dot = l.indexOf(".");
|
|
if (dot === -1) continue;
|
|
const role = l.slice(0, dot);
|
|
const level = l.slice(dot + 1);
|
|
const roleLevels = getLevelsForRole(role);
|
|
if (roleLevels.includes(level)) return level;
|
|
}
|
|
|
|
// Fallback: plain level name
|
|
const all = getAllLevels();
|
|
return all.find((l) => lower.includes(l)) ?? null;
|
|
}
|
|
|
|
/**
|
|
* Detect role and level from colon-format labels (e.g. "developer:senior").
|
|
* Returns the first match found, or null if no role:level label exists.
|
|
*/
|
|
export function detectRoleLevelFromLabels(
|
|
labels: string[],
|
|
): { role: string; level: string } | null {
|
|
for (const label of labels) {
|
|
const colon = label.indexOf(":");
|
|
if (colon === -1) continue;
|
|
const role = label.slice(0, colon).toLowerCase();
|
|
const level = label.slice(colon + 1).toLowerCase();
|
|
const roleLevels = getLevelsForRole(role);
|
|
if (roleLevels.includes(level)) return { role, level };
|
|
}
|
|
return null;
|
|
}
|
|
|
|
/**
|
|
* Detect step routing from labels (e.g. "review:human", "test:skip").
|
|
* Returns the routing value for the given step, or null if no routing label exists.
|
|
*/
|
|
export function detectStepRouting(
|
|
labels: string[], step: string,
|
|
): string | null {
|
|
const prefix = `${step}:`;
|
|
const match = labels.find((l) => l.toLowerCase().startsWith(prefix));
|
|
return match ? match.slice(prefix.length).toLowerCase() : null;
|
|
}
|
|
|
|
/**
|
|
* Detect role from a label using workflow config.
|
|
*/
|
|
export function detectRoleFromLabel(
|
|
label: StateLabel,
|
|
workflow: WorkflowConfig,
|
|
): Role | null {
|
|
return workflowDetectRole(workflow, label);
|
|
}
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Issue queue queries
|
|
// ---------------------------------------------------------------------------
|
|
|
|
export async function findNextIssueForRole(
|
|
provider: Pick<IssueProvider, "listIssuesByLabel">,
|
|
role: Role,
|
|
workflow: WorkflowConfig,
|
|
): Promise<{ issue: Issue; label: StateLabel } | null> {
|
|
const labels = getQueueLabels(workflow, role);
|
|
for (const label of labels) {
|
|
try {
|
|
const issues = await provider.listIssuesByLabel(label);
|
|
if (issues.length > 0) return { issue: issues[issues.length - 1], label };
|
|
} catch { /* continue */ }
|
|
}
|
|
return null;
|
|
}
|
|
|
|
/**
|
|
* Find next issue for any role (optional filter). Used by work_start for auto-detection.
|
|
*/
|
|
export async function findNextIssue(
|
|
provider: Pick<IssueProvider, "listIssuesByLabel">,
|
|
role: Role | undefined,
|
|
workflow: WorkflowConfig,
|
|
): Promise<{ issue: Issue; label: StateLabel } | null> {
|
|
const labels = role
|
|
? getQueueLabels(workflow, role)
|
|
: getAllQueueLabels(workflow);
|
|
|
|
for (const label of labels) {
|
|
try {
|
|
const issues = await provider.listIssuesByLabel(label);
|
|
if (issues.length > 0) return { issue: issues[issues.length - 1], label };
|
|
} catch { /* continue */ }
|
|
}
|
|
return null;
|
|
}
|