f7aa47102f
- Updated role references from "QA" to "Tester" in workflow and code comments. - Revised documentation to reflect the new role structure, including role instructions and completion rules. - Enhanced the testing guide with clearer instructions and examples for unit and E2E tests. - Improved tools reference to align with the new role definitions and completion rules. - Adjusted the roadmap to highlight recent changes in role configuration and workflow state machine.
121 lines
3.4 KiB
Markdown
121 lines
3.4 KiB
Markdown
# DevClaw — QA Workflow
|
|
|
|
Quality Assurance in DevClaw follows a structured workflow that ensures every review is documented and traceable.
|
|
|
|
## Required Steps
|
|
|
|
### 1. Review the Code
|
|
|
|
- Pull latest from the base branch
|
|
- Run tests and linting
|
|
- Verify changes address issue requirements
|
|
- Check for regressions in related functionality
|
|
|
|
### 2. Document Your Review (REQUIRED)
|
|
|
|
Before completing your task, you MUST create a review comment using `task_comment`:
|
|
|
|
```javascript
|
|
task_comment({
|
|
projectGroupId: "<group-id>",
|
|
issueId: <issue-number>,
|
|
body: "## QA Review\n\n**Tested:**\n- [List what you tested]\n\n**Results:**\n- [Pass/fail details]\n\n**Environment:**\n- [Test environment details]",
|
|
authorRole: "tester"
|
|
})
|
|
```
|
|
|
|
### 3. Complete the Task
|
|
|
|
After posting your comment, call `work_finish`:
|
|
|
|
```javascript
|
|
work_finish({
|
|
role: "tester",
|
|
projectGroupId: "<group-id>",
|
|
result: "pass", // or "fail", "refine", "blocked"
|
|
summary: "Brief summary of review outcome"
|
|
})
|
|
```
|
|
|
|
## TESTER Results
|
|
|
|
| Result | Label transition | Meaning |
|
|
|---|---|---|
|
|
| `"pass"` | Testing → Done | Approved. Issue closed. |
|
|
| `"fail"` | Testing → To Improve | Issues found. Issue reopened, sent back to DEVELOPER. |
|
|
| `"refine"` | Testing → Refining | Needs human decision. Pipeline pauses. |
|
|
| `"blocked"` | Testing → Refining | Cannot complete (env issues, etc.). Awaits human decision. |
|
|
|
|
## Why Comments Are Required
|
|
|
|
1. **Audit Trail** — Every review decision is documented in the issue tracker
|
|
2. **Knowledge Sharing** — Future reviewers understand what was tested
|
|
3. **Quality Metrics** — Enables tracking of test coverage
|
|
4. **Debugging** — When issues arise later, we know what was checked
|
|
5. **Compliance** — Some projects require documented QA evidence
|
|
|
|
## Comment Templates
|
|
|
|
### For Passing Reviews
|
|
|
|
```markdown
|
|
## QA Review
|
|
|
|
**Tested:**
|
|
- Feature A: [specific test cases]
|
|
- Feature B: [specific test cases]
|
|
- Edge cases: [list]
|
|
|
|
**Results:** All tests passed. No regressions found.
|
|
|
|
**Environment:**
|
|
- Browser/Platform: [details]
|
|
- Version: [details]
|
|
- Test data: [if relevant]
|
|
|
|
**Notes:** [Optional observations or recommendations]
|
|
```
|
|
|
|
### For Failing Reviews
|
|
|
|
```markdown
|
|
## QA Review — Issues Found
|
|
|
|
**Tested:**
|
|
- [What you tested]
|
|
|
|
**Issues Found:**
|
|
1. [Issue description with steps to reproduce]
|
|
2. [Issue description with expected vs actual behavior]
|
|
|
|
**Environment:**
|
|
- [Test environment details]
|
|
|
|
**Severity:** [Critical/Major/Minor]
|
|
```
|
|
|
|
## Enforcement
|
|
|
|
TESTER workers receive instructions via role templates to:
|
|
- Always call `task_comment` BEFORE `work_finish`
|
|
- Include specific details about what was tested
|
|
- Document results, environment, and any notes
|
|
|
|
Prompt templates affected:
|
|
- `devclaw/projects/<project>/prompts/tester.md`
|
|
- `devclaw/prompts/tester.md` (default)
|
|
|
|
## Best Practices
|
|
|
|
1. **Be Specific** — Don't just say "tested the feature" — list what you tested
|
|
2. **Include Environment** — Version numbers, browser, OS can matter
|
|
3. **Document Edge Cases** — If you tested special scenarios, note them
|
|
4. **Reference Requirements** — Link back to acceptance criteria from the issue
|
|
5. **Use Screenshots** — For UI issues, screenshots help (link in comment)
|
|
|
|
## Related
|
|
|
|
- Tool: [`task_comment`](TOOLS.md#task_comment) — Add comments to issues
|
|
- Tool: [`work_finish`](TOOLS.md#work_finish) — Complete TESTER tasks
|
|
- Config: [`devclaw/projects/<project>/prompts/tester.md`](CONFIGURATION.md#role-instruction-files) — Tester role instructions
|