Adds the Architect role for design/architecture investigations with persistent sessions and structured design proposals. ## New Features - **Architect role** with opus (complex) and sonnet (standard) levels - **design_task tool** — Creates To Design issues and dispatches architect - **Workflow states:** To Design → Designing → Planning - **Completion rules:** architect:done → Planning, architect:blocked → Refining - **Auto-level selection** based on complexity keywords ## Files Changed (22 files, 546 additions) ### New Files - lib/tools/design-task.ts — design_task tool implementation - lib/tools/design-task.test.ts — 16 tests for architect functionality ### Core Changes - lib/tiers.ts — ARCHITECT_LEVELS, WorkerRole type, models, emoji - lib/workflow.ts — toDesign/designing states, completion rules - lib/projects.ts — architect WorkerState on Project type - lib/dispatch.ts — architect role support in dispatch pipeline - lib/services/pipeline.ts — architect completion rules - lib/model-selector.ts — architect level selection heuristic ### Integration - index.ts — Register design_task tool, architect config schema - lib/notify.ts — architect role in notifications - lib/bootstrap-hook.ts — architect session key parsing - lib/services/tick.ts — architect in queue processing - lib/services/heartbeat.ts — architect in health checks - lib/tools/health.ts — architect in health scans - lib/tools/status.ts — architect in status dashboard - lib/tools/work-start.ts — architect role option - lib/tools/work-finish.ts — architect validation - lib/tools/project-register.ts — architect labels + role scaffolding - lib/templates.ts — architect instructions + AGENTS.md updates - lib/setup/workspace.ts — architect role file scaffolding - lib/setup/smart-model-selector.ts — architect in model assignment - lib/setup/llm-model-selector.ts — architect in LLM prompt
414 lines
12 KiB
TypeScript
414 lines
12 KiB
TypeScript
/**
|
|
* workflow.ts — XState-style statechart configuration for workflow states.
|
|
*
|
|
* The workflow config defines:
|
|
* - States with types (queue, active, hold, terminal)
|
|
* - Transitions with actions (gitPull, detectPr, closeIssue, reopenIssue)
|
|
* - Role assignments (dev, qa)
|
|
* - Priority ordering for queue states
|
|
*
|
|
* All workflow behavior is derived from this config — no hardcoded state names.
|
|
*/
|
|
import fs from "node:fs/promises";
|
|
import path from "node:path";
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Types
|
|
// ---------------------------------------------------------------------------
|
|
|
|
export type StateType = "queue" | "active" | "hold" | "terminal";
|
|
export type Role = "dev" | "qa" | "architect";
|
|
export type TransitionAction = "gitPull" | "detectPr" | "closeIssue" | "reopenIssue";
|
|
|
|
export type TransitionTarget = string | {
|
|
target: string;
|
|
actions?: TransitionAction[];
|
|
};
|
|
|
|
export type StateConfig = {
|
|
type: StateType;
|
|
role?: Role;
|
|
label: string;
|
|
color: string;
|
|
priority?: number;
|
|
on?: Record<string, TransitionTarget>;
|
|
};
|
|
|
|
export type WorkflowConfig = {
|
|
initial: string;
|
|
states: Record<string, StateConfig>;
|
|
};
|
|
|
|
export type CompletionRule = {
|
|
from: string;
|
|
to: string;
|
|
gitPull?: boolean;
|
|
detectPr?: boolean;
|
|
closeIssue?: boolean;
|
|
reopenIssue?: boolean;
|
|
};
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Default workflow — matches current hardcoded behavior
|
|
// ---------------------------------------------------------------------------
|
|
|
|
export const DEFAULT_WORKFLOW: WorkflowConfig = {
|
|
initial: "planning",
|
|
states: {
|
|
planning: {
|
|
type: "hold",
|
|
label: "Planning",
|
|
color: "#95a5a6",
|
|
on: { APPROVE: "todo" },
|
|
},
|
|
todo: {
|
|
type: "queue",
|
|
role: "dev",
|
|
label: "To Do",
|
|
color: "#428bca",
|
|
priority: 1,
|
|
on: { PICKUP: "doing" },
|
|
},
|
|
doing: {
|
|
type: "active",
|
|
role: "dev",
|
|
label: "Doing",
|
|
color: "#f0ad4e",
|
|
on: {
|
|
COMPLETE: { target: "toTest", actions: ["gitPull", "detectPr"] },
|
|
BLOCKED: "refining",
|
|
},
|
|
},
|
|
toTest: {
|
|
type: "queue",
|
|
role: "qa",
|
|
label: "To Test",
|
|
color: "#5bc0de",
|
|
priority: 2,
|
|
on: { PICKUP: "testing" },
|
|
},
|
|
testing: {
|
|
type: "active",
|
|
role: "qa",
|
|
label: "Testing",
|
|
color: "#9b59b6",
|
|
on: {
|
|
PASS: { target: "done", actions: ["closeIssue"] },
|
|
FAIL: { target: "toImprove", actions: ["reopenIssue"] },
|
|
REFINE: "refining",
|
|
BLOCKED: "refining",
|
|
},
|
|
},
|
|
toImprove: {
|
|
type: "queue",
|
|
role: "dev",
|
|
label: "To Improve",
|
|
color: "#d9534f",
|
|
priority: 3,
|
|
on: { PICKUP: "doing" },
|
|
},
|
|
refining: {
|
|
type: "hold",
|
|
label: "Refining",
|
|
color: "#f39c12",
|
|
on: { APPROVE: "todo" },
|
|
},
|
|
done: {
|
|
type: "terminal",
|
|
label: "Done",
|
|
color: "#5cb85c",
|
|
},
|
|
toDesign: {
|
|
type: "queue",
|
|
role: "architect",
|
|
label: "To Design",
|
|
color: "#0075ca",
|
|
priority: 1,
|
|
on: { PICKUP: "designing" },
|
|
},
|
|
designing: {
|
|
type: "active",
|
|
role: "architect",
|
|
label: "Designing",
|
|
color: "#d4c5f9",
|
|
on: {
|
|
COMPLETE: "planning",
|
|
BLOCKED: "refining",
|
|
},
|
|
},
|
|
},
|
|
};
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Workflow loading
|
|
// ---------------------------------------------------------------------------
|
|
|
|
/**
|
|
* Load workflow config for a project.
|
|
* Priority: project-specific → workspace default → built-in default
|
|
*/
|
|
export async function loadWorkflow(
|
|
workspaceDir: string,
|
|
_groupId?: string,
|
|
): Promise<WorkflowConfig> {
|
|
// TODO: Support per-project overrides from projects.json when needed
|
|
// For now, try workspace-level config, fall back to default
|
|
|
|
const workflowPath = path.join(workspaceDir, "projects", "workflow.json");
|
|
try {
|
|
const content = await fs.readFile(workflowPath, "utf-8");
|
|
const parsed = JSON.parse(content) as { workflow?: WorkflowConfig };
|
|
if (parsed.workflow) {
|
|
return mergeWorkflow(DEFAULT_WORKFLOW, parsed.workflow);
|
|
}
|
|
} catch {
|
|
// No custom workflow, use default
|
|
}
|
|
|
|
return DEFAULT_WORKFLOW;
|
|
}
|
|
|
|
/**
|
|
* Merge custom workflow config over defaults.
|
|
* Custom states are merged, not replaced entirely.
|
|
*/
|
|
function mergeWorkflow(base: WorkflowConfig, custom: Partial<WorkflowConfig>): WorkflowConfig {
|
|
return {
|
|
initial: custom.initial ?? base.initial,
|
|
states: { ...base.states, ...custom.states },
|
|
};
|
|
}
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Derived helpers — all behavior comes from the config
|
|
// ---------------------------------------------------------------------------
|
|
|
|
/**
|
|
* Get all state labels (for GitHub/GitLab label creation).
|
|
*/
|
|
export function getStateLabels(workflow: WorkflowConfig): string[] {
|
|
return Object.values(workflow.states).map((s) => s.label);
|
|
}
|
|
|
|
/**
|
|
* Get label → color mapping.
|
|
*/
|
|
export function getLabelColors(workflow: WorkflowConfig): Record<string, string> {
|
|
const colors: Record<string, string> = {};
|
|
for (const state of Object.values(workflow.states)) {
|
|
colors[state.label] = state.color;
|
|
}
|
|
return colors;
|
|
}
|
|
|
|
/**
|
|
* Get queue labels for a role, ordered by priority (highest first).
|
|
*/
|
|
export function getQueueLabels(workflow: WorkflowConfig, role: Role): string[] {
|
|
return Object.values(workflow.states)
|
|
.filter((s) => s.type === "queue" && s.role === role)
|
|
.sort((a, b) => (b.priority ?? 0) - (a.priority ?? 0))
|
|
.map((s) => s.label);
|
|
}
|
|
|
|
/**
|
|
* Get all queue labels ordered by priority (for findNextIssue).
|
|
*/
|
|
export function getAllQueueLabels(workflow: WorkflowConfig): string[] {
|
|
return Object.values(workflow.states)
|
|
.filter((s) => s.type === "queue")
|
|
.sort((a, b) => (b.priority ?? 0) - (a.priority ?? 0))
|
|
.map((s) => s.label);
|
|
}
|
|
|
|
/**
|
|
* Get the active (in-progress) label for a role.
|
|
*/
|
|
export function getActiveLabel(workflow: WorkflowConfig, role: Role): string {
|
|
const state = Object.values(workflow.states).find(
|
|
(s) => s.type === "active" && s.role === role,
|
|
);
|
|
if (!state) throw new Error(`No active state for role "${role}"`);
|
|
return state.label;
|
|
}
|
|
|
|
/**
|
|
* Get the revert label for a role (first queue state for that role).
|
|
*/
|
|
export function getRevertLabel(workflow: WorkflowConfig, role: Role): string {
|
|
// Find the state that PICKUP transitions to the active state, then find its label
|
|
const activeLabel = getActiveLabel(workflow, role);
|
|
const activeStateKey = Object.entries(workflow.states).find(
|
|
([, s]) => s.label === activeLabel,
|
|
)?.[0];
|
|
|
|
// Find queue states that transition to this active state
|
|
for (const [, state] of Object.entries(workflow.states)) {
|
|
if (state.type !== "queue" || state.role !== role) continue;
|
|
const pickup = state.on?.PICKUP;
|
|
if (pickup === activeStateKey) {
|
|
return state.label;
|
|
}
|
|
}
|
|
|
|
// Fallback: first queue state for role
|
|
return getQueueLabels(workflow, role)[0] ?? "";
|
|
}
|
|
|
|
/**
|
|
* Detect role from a label.
|
|
*/
|
|
export function detectRoleFromLabel(workflow: WorkflowConfig, label: string): Role | null {
|
|
for (const state of Object.values(workflow.states)) {
|
|
if (state.label === label && state.type === "queue" && state.role) {
|
|
return state.role;
|
|
}
|
|
}
|
|
return null;
|
|
}
|
|
|
|
/**
|
|
* Check if a label is a queue label.
|
|
*/
|
|
export function isQueueLabel(workflow: WorkflowConfig, label: string): boolean {
|
|
return Object.values(workflow.states).some(
|
|
(s) => s.label === label && s.type === "queue",
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Check if a label is an active label.
|
|
*/
|
|
export function isActiveLabel(workflow: WorkflowConfig, label: string): boolean {
|
|
return Object.values(workflow.states).some(
|
|
(s) => s.label === label && s.type === "active",
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Find state config by label.
|
|
*/
|
|
export function findStateByLabel(workflow: WorkflowConfig, label: string): StateConfig | null {
|
|
return Object.values(workflow.states).find((s) => s.label === label) ?? null;
|
|
}
|
|
|
|
/**
|
|
* Find state key by label.
|
|
*/
|
|
export function findStateKeyByLabel(workflow: WorkflowConfig, label: string): string | null {
|
|
return Object.entries(workflow.states).find(([, s]) => s.label === label)?.[0] ?? null;
|
|
}
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Completion rules — derived from transitions
|
|
// ---------------------------------------------------------------------------
|
|
|
|
/**
|
|
* Map role:result to completion event name.
|
|
*/
|
|
const RESULT_TO_EVENT: Record<string, string> = {
|
|
"dev:done": "COMPLETE",
|
|
"dev:blocked": "BLOCKED",
|
|
"qa:pass": "PASS",
|
|
"qa:fail": "FAIL",
|
|
"qa:refine": "REFINE",
|
|
"qa:blocked": "BLOCKED",
|
|
"architect:done": "COMPLETE",
|
|
"architect:blocked": "BLOCKED",
|
|
};
|
|
|
|
/**
|
|
* Get completion rule for a role:result pair.
|
|
*/
|
|
export function getCompletionRule(
|
|
workflow: WorkflowConfig,
|
|
role: Role,
|
|
result: string,
|
|
): CompletionRule | null {
|
|
const event = RESULT_TO_EVENT[`${role}:${result}`];
|
|
if (!event) return null;
|
|
|
|
const activeLabel = getActiveLabel(workflow, role);
|
|
const activeKey = findStateKeyByLabel(workflow, activeLabel);
|
|
if (!activeKey) return null;
|
|
|
|
const activeState = workflow.states[activeKey];
|
|
if (!activeState.on) return null;
|
|
|
|
const transition = activeState.on[event];
|
|
if (!transition) return null;
|
|
|
|
const targetKey = typeof transition === "string" ? transition : transition.target;
|
|
const actions = typeof transition === "object" ? transition.actions : undefined;
|
|
const targetState = workflow.states[targetKey];
|
|
if (!targetState) return null;
|
|
|
|
return {
|
|
from: activeLabel,
|
|
to: targetState.label,
|
|
gitPull: actions?.includes("gitPull"),
|
|
detectPr: actions?.includes("detectPr"),
|
|
closeIssue: actions?.includes("closeIssue"),
|
|
reopenIssue: actions?.includes("reopenIssue"),
|
|
};
|
|
}
|
|
|
|
/**
|
|
* Get human-readable next state description.
|
|
*/
|
|
export function getNextStateDescription(
|
|
workflow: WorkflowConfig,
|
|
role: Role,
|
|
result: string,
|
|
): string {
|
|
const rule = getCompletionRule(workflow, role, result);
|
|
if (!rule) return "";
|
|
|
|
// Find the target state to determine the description
|
|
const targetState = findStateByLabel(workflow, rule.to);
|
|
if (!targetState) return "";
|
|
|
|
if (targetState.type === "terminal") return "Done!";
|
|
if (targetState.type === "hold") return "awaiting human decision";
|
|
if (targetState.type === "queue") {
|
|
if (targetState.role === "qa") return "QA queue";
|
|
if (targetState.role === "dev") return "back to DEV";
|
|
}
|
|
|
|
return rule.to;
|
|
}
|
|
|
|
/**
|
|
* Get emoji for a completion result.
|
|
*/
|
|
export function getCompletionEmoji(role: Role, result: string): string {
|
|
const map: Record<string, string> = {
|
|
"dev:done": "✅",
|
|
"qa:pass": "🎉",
|
|
"qa:fail": "❌",
|
|
"qa:refine": "🤔",
|
|
"dev:blocked": "🚫",
|
|
"qa:blocked": "🚫",
|
|
"architect:done": "🏗️",
|
|
"architect:blocked": "🚫",
|
|
};
|
|
return map[`${role}:${result}`] ?? "📋";
|
|
}
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Sync helper — ensure workflow states exist as labels in issue tracker
|
|
// ---------------------------------------------------------------------------
|
|
|
|
/**
|
|
* Ensure all workflow state labels exist in the issue tracker.
|
|
*/
|
|
export async function ensureWorkflowLabels(
|
|
workflow: WorkflowConfig,
|
|
ensureLabel: (name: string, color: string) => Promise<void>,
|
|
): Promise<void> {
|
|
const colors = getLabelColors(workflow);
|
|
for (const [label, color] of Object.entries(colors)) {
|
|
await ensureLabel(label, color);
|
|
}
|
|
}
|