## Summary
Introduces a configurable workflow state machine that replaces all hardcoded
state labels. The default workflow matches current behavior exactly, ensuring
backward compatibility.
## Architecture
### lib/workflow.ts — Core workflow engine
XState-style statechart configuration:
```typescript
type StateConfig = {
type: 'queue' | 'active' | 'hold' | 'terminal';
role?: 'dev' | 'qa';
label: string;
color: string;
priority?: number;
on?: Record<string, TransitionTarget>;
};
```
All behavior is derived from the config:
- Queue states: `type: 'queue'`, grouped by role, ordered by priority
- Active states: `type: 'active'` — worker occupied
- Transitions: defined with optional actions (gitPull, detectPr, closeIssue, reopenIssue)
- Labels and colors: derived from state.label and state.color
### Derivation functions
- `getStateLabels()` — all labels for issue tracker sync
- `getLabelColors()` — label → color mapping
- `getQueueLabels(role)` — queue labels for a role, ordered by priority
- `getActiveLabel(role)` — the active/in-progress label for a role
- `getRevertLabel(role)` — queue label to revert to on failure
- `detectRoleFromLabel()` — detect role from a queue label
- `getCompletionRule(role, result)` — derive transition rule from config
## Files Changed
- **lib/workflow.ts** — NEW: workflow engine and default config
- **lib/providers/provider.ts** — deprecate STATE_LABELS, LABEL_COLORS; derive from workflow
- **lib/providers/github.ts** — use workflow config for label operations
- **lib/providers/gitlab.ts** — use workflow config for label operations
- **lib/services/pipeline.ts** — use getCompletionRule() from workflow
- **lib/services/tick.ts** — use workflow for queue/active labels
- **lib/services/health.ts** — use workflow for active/revert labels
- **lib/tools/work-start.ts** — use workflow for target label
## Backward Compatibility
- DEFAULT_WORKFLOW matches current hardcoded behavior exactly
- Deprecated exports kept for any external consumers
- No breaking changes to tool interfaces or project state
## Future Work
- Load per-project workflow overrides from projects.json
- User-facing config in projects/workflow.json
- Tool schema generation from workflow states
134 lines
5.3 KiB
TypeScript
134 lines
5.3 KiB
TypeScript
/**
|
|
* GitLabProvider — IssueProvider implementation using glab CLI.
|
|
*/
|
|
import {
|
|
type IssueProvider,
|
|
type Issue,
|
|
type StateLabel,
|
|
type IssueComment,
|
|
} from "./provider.js";
|
|
import { runCommand } from "../run-command.js";
|
|
import {
|
|
DEFAULT_WORKFLOW,
|
|
getStateLabels,
|
|
getLabelColors,
|
|
type WorkflowConfig,
|
|
} from "../workflow.js";
|
|
|
|
export class GitLabProvider implements IssueProvider {
|
|
private repoPath: string;
|
|
private workflow: WorkflowConfig;
|
|
|
|
constructor(opts: { repoPath: string; workflow?: WorkflowConfig }) {
|
|
this.repoPath = opts.repoPath;
|
|
this.workflow = opts.workflow ?? DEFAULT_WORKFLOW;
|
|
}
|
|
|
|
private async glab(args: string[]): Promise<string> {
|
|
const result = await runCommand(["glab", ...args], { timeoutMs: 30_000, cwd: this.repoPath });
|
|
return result.stdout.trim();
|
|
}
|
|
|
|
async ensureLabel(name: string, color: string): Promise<void> {
|
|
try { await this.glab(["label", "create", "--name", name, "--color", color]); }
|
|
catch (err) { const msg = (err as Error).message ?? ""; if (!msg.includes("already exists") && !msg.includes("409")) throw err; }
|
|
}
|
|
|
|
async ensureAllStateLabels(): Promise<void> {
|
|
const labels = getStateLabels(this.workflow);
|
|
const colors = getLabelColors(this.workflow);
|
|
for (const label of labels) {
|
|
await this.ensureLabel(label, colors[label]);
|
|
}
|
|
}
|
|
|
|
async createIssue(title: string, description: string, label: StateLabel, assignees?: string[]): Promise<Issue> {
|
|
// Pass description directly as argv — runCommand uses spawn (no shell),
|
|
// so no escaping issues with special characters.
|
|
const args = ["issue", "create", "--title", title, "--description", description, "--label", label];
|
|
if (assignees?.length) args.push("--assignee", assignees.join(","));
|
|
const stdout = await this.glab(args);
|
|
// glab issue create returns the issue URL
|
|
const match = stdout.match(/\/issues\/(\d+)/);
|
|
if (!match) throw new Error(`Failed to parse issue URL: ${stdout}`);
|
|
return this.getIssue(parseInt(match[1], 10));
|
|
}
|
|
|
|
async listIssuesByLabel(label: StateLabel): Promise<Issue[]> {
|
|
try {
|
|
const raw = await this.glab(["issue", "list", "--label", label, "--output", "json"]);
|
|
return JSON.parse(raw) as Issue[];
|
|
} catch { return []; }
|
|
}
|
|
|
|
async getIssue(issueId: number): Promise<Issue> {
|
|
const raw = await this.glab(["issue", "view", String(issueId), "--output", "json"]);
|
|
return JSON.parse(raw) as Issue;
|
|
}
|
|
|
|
async listComments(issueId: number): Promise<IssueComment[]> {
|
|
try {
|
|
const raw = await this.glab(["api", `projects/:id/issues/${issueId}/notes`, "--paginate"]);
|
|
const notes = JSON.parse(raw) as Array<{ author: { username: string }; body: string; created_at: string; system: boolean }>;
|
|
// Filter out system notes (e.g. "changed label", "closed issue")
|
|
return notes
|
|
.filter((note) => !note.system)
|
|
.map((note) => ({
|
|
author: note.author.username,
|
|
body: note.body,
|
|
created_at: note.created_at,
|
|
}));
|
|
} catch { return []; }
|
|
}
|
|
|
|
async transitionLabel(issueId: number, from: StateLabel, to: StateLabel): Promise<void> {
|
|
const issue = await this.getIssue(issueId);
|
|
const stateLabels = getStateLabels(this.workflow);
|
|
const currentStateLabels = issue.labels.filter((l) => stateLabels.includes(l));
|
|
const args = ["issue", "update", String(issueId)];
|
|
for (const l of currentStateLabels) args.push("--unlabel", l);
|
|
args.push("--label", to);
|
|
await this.glab(args);
|
|
}
|
|
|
|
async closeIssue(issueId: number): Promise<void> { await this.glab(["issue", "close", String(issueId)]); }
|
|
async reopenIssue(issueId: number): Promise<void> { await this.glab(["issue", "reopen", String(issueId)]); }
|
|
|
|
hasStateLabel(issue: Issue, expected: StateLabel): boolean { return issue.labels.includes(expected); }
|
|
|
|
getCurrentStateLabel(issue: Issue): StateLabel | null {
|
|
const stateLabels = getStateLabels(this.workflow);
|
|
return stateLabels.find((l) => issue.labels.includes(l)) ?? null;
|
|
}
|
|
|
|
async hasMergedMR(issueId: number): Promise<boolean> {
|
|
try {
|
|
const raw = await this.glab(["mr", "list", "--output", "json", "--state", "merged"]);
|
|
const mrs = JSON.parse(raw) as Array<{ title: string; description: string }>;
|
|
const pat = `#${issueId}`;
|
|
return mrs.some((mr) => mr.title.includes(pat) || (mr.description ?? "").includes(pat));
|
|
} catch { return false; }
|
|
}
|
|
|
|
async getMergedMRUrl(issueId: number): Promise<string | null> {
|
|
try {
|
|
const raw = await this.glab(["mr", "list", "--output", "json", "--state", "merged"]);
|
|
const mrs = JSON.parse(raw) as Array<{ iid: number; title: string; description: string; web_url: string; merged_at: string }>;
|
|
const pat = `#${issueId}`;
|
|
const mr = mrs
|
|
.filter((mr) => mr.title.includes(pat) || (mr.description ?? "").includes(pat))
|
|
.sort((a, b) => new Date(b.merged_at).getTime() - new Date(a.merged_at).getTime())[0];
|
|
return mr?.web_url ?? null;
|
|
} catch { return null; }
|
|
}
|
|
|
|
async addComment(issueId: number, body: string): Promise<void> {
|
|
// Pass message directly as argv — no shell escaping needed with spawn
|
|
await this.glab(["issue", "note", String(issueId), "--message", body]);
|
|
}
|
|
|
|
async healthCheck(): Promise<boolean> {
|
|
try { await this.glab(["auth", "status"]); return true; } catch { return false; }
|
|
}
|
|
}
|