Commit Graph

191 Commits

Author SHA1 Message Date
Lauren ten Hoor
41caa13050 Merge pull request #112 from laurentenhoor/fix/108-stale-worker-duration
fix: reset startTime on task assignment for accurate duration tracking
2026-02-10 22:56:48 +08:00
Lauren ten Hoor
226579086f fix: reset startTime on task assignment for accurate duration tracking
Problem:
Stale worker detection was reporting incorrect durations when sessions
were reused. Workers showed total session lifetime rather than time
since current task assignment.

Example:
- Session created 13 hours ago for issue #71
- Session reused 4 minutes ago for issue #106
- Status incorrectly showed: "DEV active on #106 (3.3h)"
- Should show: "DEV active on #106 (4m)"

Root Cause:
In recordWorkerState(), startTime was only set when spawning a new
session (sessionAction === 'spawn'). When reusing an existing session
(sessionAction === 'send'), the old startTime persisted, causing
stale worker detection to use total session age instead of task age.

Solution:
Always set startTime to current time when activating a worker,
regardless of whether we're spawning a new session or reusing one.
The startTime field now consistently represents "when did this worker
start THIS specific task" rather than "when was the session created".

Changes:
- lib/dispatch.ts: Move startTime assignment outside spawn-only block
- startTime now set unconditionally for both spawn and send actions
- Maintains backward compatibility with existing health checks

Impact:
- Stale worker detection now accurately reflects task duration
- Session reuse no longer causes false positive stale alerts
- Duration shown in status matches actual time on current task

Addresses issue #108
2026-02-10 22:56:05 +08:00
Lauren ten Hoor
7b83a8fe82 Merge fix/111-remove-next-md: Remove NEXT.md from repository
Addresses issue #111
2026-02-10 22:54:04 +08:00
Lauren ten Hoor
1c2667f457 chore: remove NEXT.md from repository (#111) 2026-02-10 22:53:51 +08:00
Lauren ten Hoor
70af40e986 Refactor setup and tool helpers for improved modularity and clarity
- Moved setup logic into dedicated files: agent.ts, config.ts, index.ts, workspace.ts.
- Introduced tool-helpers.ts for shared functions across tools, reducing boilerplate.
- Updated tools (status, task-comment, task-create, task-update, work-finish, work-start) to utilize new helper functions for workspace resolution and provider creation.
- Enhanced error handling and context detection in tools.
- Improved project resolution logic to streamline tool execution.
- Added new functionality for agent creation and configuration management in setup.
2026-02-10 22:51:35 +08:00
Lauren ten Hoor
55b062ac76 refactor: replace autoChain with projectTick queue scanning
Remove hard-coded auto-chain dispatch (DEV done→QA, QA fail→DEV) and
replace with a general-purpose projectTick service that scans the queue
and fills free worker slots after every state transition.

- Create lib/services/tick.ts: consolidates shared helpers and core
  projectTick() function from duplicated code in work-start/auto-pickup
- work_finish: replaces auto-chain block with projectTick call
- work_start: adds projectTick after dispatch to fill parallel slots
- auto_pickup: delegates per-project loop to projectTick
- Remove autoChain from Project type, migration code, and project-register
- Remove scheduling config dependency from work_finish
- Net -112 lines: simpler, self-healing pipeline

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-10 21:46:11 +08:00
Lauren ten Hoor
d7178bb8e5 refactor: reorganize task management imports and update task handling tools
- Updated import paths for task management providers in task-comment, task-create, and task-update tools.
- Removed deprecated task-complete and task-pickup tools, replacing them with work-finish and work-start tools for improved task handling.
- Enhanced work-finish and work-start tools to streamline task completion and pickup processes, including context-aware detection and auto-scheduling features.
- Updated package.json to include build scripts and main entry point.
- Modified tsconfig.json to enable output directory, declaration files, and source maps for better TypeScript support.
2026-02-10 21:39:41 +08:00
Lauren ten Hoor
c1c3e09a8e feat: update issue creation to return issue object instead of raw output 2026-02-10 21:11:37 +08:00
Lauren ten Hoor
99fa164ab3 Merge pull request #110 from laurentenhoor/feature/109-auto-share-ticket-url
feat: auto-share ticket URL after task_create
2026-02-10 20:37:19 +08:00
Lauren ten Hoor
5b601c7db3 feat: auto-share ticket URL after task_create
Automatically includes the issue URL in the announcement when
task_create is called, eliminating the need for users to ask
'What's the URL?' after creating a task.

Changes:
- Enhanced announcement formatting with line breaks
- Always includes issue URL with 🔗 prefix
- Improved readability with structured format

Example output:
📋 Created #109: "Fix bug" (To Do)
🔗 https://github.com/user/repo/issues/109
Ready for pickup when needed.

Example with description:
📋 Created #110: "Add feature" (Planning)
With detailed description.
🔗 https://github.com/user/repo/issues/110
Picking up for DEV...

Addresses issue #109
2026-02-10 20:36:39 +08:00
Lauren ten Hoor
4540c9af30 Merge pull request #107 from laurentenhoor/feature/106-enhance-notification-urls
feat: enhance notification URLs with issue links and tool aliases
2026-02-10 20:33:30 +08:00
Lauren ten Hoor
2260f39383 feat: enhance notification URLs with issue links and tool aliases
Improvements to notification system for better traceability:

1. DEV Completion Notifications:
   - Always include issue URL (📋 Issue: ...)
   - Include PR/MR URL when available (🔗 PR: ...)
   - Issue URL serves as fallback when PR/MR not found
   - Both URLs shown when PR/MR exists for maximum traceability

2. QA Pass Notifications:
   - Now include issue URL (📋 Issue: ...)
   - Provides direct link to resolved issue

3. Tool Aliases:
   - Added 'work_finish' as alias for 'task_complete'
   - Added 'work_start' as alias for 'task_pickup'
   - Added 'status' as alias for 'queue_status'
   - Matches naming used in AGENTS.md documentation

Example DEV notification:
 DEV done #106 — Enhanced notification URLs
📋 Issue: https://github.com/user/repo/issues/106
🔗 PR: https://github.com/user/repo/pull/107
Moved to QA queue.

Example QA notification:
🎉 QA PASS #106 — All tests passed
📋 Issue: https://github.com/user/repo/issues/106
Issue closed.

Addresses issue #106
2026-02-10 20:32:51 +08:00
Lauren ten Hoor
7339a8395d Merge feat/105-test-md-lauren: Create TEST.md with information about Lauren ten Hoor
Addresses issue #105
2026-02-10 20:21:02 +08:00
Lauren ten Hoor
107126b167 feat: create TEST.md with information about Lauren ten Hoor (#105) 2026-02-10 20:20:51 +08:00
Lauren ten Hoor
29fafd4958 Merge pull request #104 from laurentenhoor/feature/103-enforce-qa-comments
docs: enforce QA comments on every review (pass or fail)
2026-02-10 18:54:24 +08:00
Lauren ten Hoor
624b84b5bb docs: add QA workflow documentation with comment requirements
Added comprehensive QA workflow documentation explaining:
- Required steps for QA reviews
- Mandatory task_comment before task_complete
- Comment templates for pass/fail scenarios
- Rationale for enforcement (audit trail, knowledge sharing, etc.)
- Best practices for QA documentation

This documentation supports the QA comment enforcement
introduced in role templates.

Related to issue #103
2026-02-10 18:53:43 +08:00
Lauren ten Hoor
47efdc880e Merge pull request #102 from laurentenhoor/feature/101-include-pr-url
feat: include PR/MR URL in DEV completion notifications
2026-02-10 18:23:23 +08:00
Lauren ten Hoor
09f6903ebb feat: include PR/MR URL in DEV completion notifications
Adds automatic PR/MR URL detection and inclusion in DEV completion
announcements to provide better visibility into completed work.

Changes:
1. TaskManager interface:
   - Added getMergedMRUrl() method to fetch PR/MR URL for an issue

2. GitHub/GitLab providers:
   - Implemented getMergedMRUrl() to find most recent merged PR/MR
   - Returns URL of PR/MR that references the issue number

3. task_complete tool:
   - Added optional prUrl parameter
   - Auto-detects PR/MR URL if not provided
   - Includes PR URL in announcement with 🔗 prefix
   - Format: 'PR: https://github.com/...'

4. Role templates (dev.md):
   - Updated to instruct workers to include prUrl in task_complete
   - Documents that prUrl is optional (auto-detected as fallback)

Example announcement:
 DEV done #101 — Added PR/MR URL to notifications
🔗 PR: https://github.com/user/repo/pull/102
. Moved to QA queue.

Addresses issue #101
2026-02-10 18:22:44 +08:00
Lauren ten Hoor
83e723df32 Merge fix/100-remove-test-md: Remove TEST.md file
Addresses issue #100
2026-02-10 18:18:10 +08:00
Lauren ten Hoor
15b3299c51 chore: remove TEST.md file (#100) 2026-02-10 18:17:53 +08:00
Lauren ten Hoor
decf4a23a2 Merge feat/99-add-test-md-lauren: Add TEST.md with statement about Lauren ten Hoor
Addresses issue #99
2026-02-10 18:12:25 +08:00
Lauren ten Hoor
3280620f00 feat: add TEST.md with statement about Lauren ten Hoor (#99) 2026-02-10 18:12:14 +08:00
Lauren ten Hoor
c3e8e973ef Merge pull request #98 from laurentenhoor/fix/97-clean-label-transitions
fix: ensure clean label transitions by removing all state labels
2026-02-10 18:00:19 +08:00
Lauren ten Hoor
c973c04635 fix: ensure clean label transitions by removing all state labels
Problem:
GitHub was showing confusing label transitions like:
- 'added To Do Doing and removed To Do'
- 'added To Test Testing Done and removed Doing To Test Testing'

This occurred when issues had multiple state labels simultaneously
(due to bugs, manual edits, or failed transitions).

Root Cause:
The old transitionLabel() only removed the 'from' label and added
the 'to' label. If other state labels existed on the issue, they
would remain, causing messy multi-label states.

Solution:
1. Fetch the current issue to inspect all labels
2. Find ALL state labels on the issue (not just 'from')
3. Remove ALL state labels in a single operation
4. Add only the new 'to' label

This ensures atomic, clean transitions that display on GitHub as
a single 'removed X, added Y' operation, even if the issue
previously had multiple state labels.

Changes:
- GitHubProvider.transitionLabel(): Remove all state labels before adding new one
- GitLabProvider.transitionLabel(): Same fix for GitLab consistency

Addresses issue #97
2026-02-10 17:59:57 +08:00
Lauren ten Hoor
6c20a2c38c Merge feat/96-add-test-md: Add TEST.md with dummy content
Addresses issue #96
2026-02-10 17:42:54 +08:00
Lauren ten Hoor
a824d06634 feat: add TEST.md with dummy content (#96) 2026-02-10 17:42:40 +08:00
Lauren ten Hoor
1eb63f517b Merge pull request #95 from laurentenhoor/fix/71-task-update-tool
test: add integration test skeleton for task_update tool
2026-02-10 17:18:50 +08:00
Lauren ten Hoor
3e756fc6a8 test: add integration test skeleton for task_update tool
Adds test file with validation scenarios:
- Schema validation for required/optional params
- All 8 state labels are supported
- Same-state transitions handled gracefully
- Audit logging verification

Includes manual test scenarios for integration verification.

Addresses issue #71 acceptance criteria:
 Can transition any issue to any valid state
 Logs reason to audit trail
 Updates GitHub label (projects.json managed by session_health)
 Documented as orchestrator-only in AGENTS.md
2026-02-10 17:18:21 +08:00
Lauren ten Hoor
4cd95acd20 refactor: remove unused test helpers and related test files
- Deleted `helpers.ts`, `projects.test.ts`, and `scenarios.test.ts` as they are no longer needed.
- Updated `package.json` to remove the test script that referenced the deleted files.
2026-02-10 17:02:44 +08:00
Lauren ten Hoor
880ffdf584 feat: update project name in test helpers and scenarios for consistency 2026-02-10 17:01:54 +08:00
Lauren ten Hoor
9e3279872a feat: add sessionKey to dispatch options and related tools for subagent tracking 2026-02-10 16:58:37 +08:00
Lauren ten Hoor
04f4f6ebc6 Merge fix/90-remove-test-md: Remove TEST.md file
Addresses issue #90
2026-02-10 16:51:30 +08:00
Lauren ten Hoor
d03055a3cf chore: remove TEST.md file (#90) 2026-02-10 16:51:18 +08:00
Lauren ten Hoor
52c7b232d7 feat: add TEST.md with testing content (issue #88) (#89) 2026-02-10 16:14:01 +08:00
Lauren ten Hoor
a52f2e7070 chore: delete TEST.md (issue #86) (#87) 2026-02-10 15:52:00 +08:00
Lauren ten Hoor
4f2be8e551 feat: create TEST.md markdown file (#78) 2026-02-10 15:48:16 +08:00
Lauren ten Hoor
682202e447 Create TEST.md markdown file (#79)
As described in issue #78
2026-02-10 15:26:23 +08:00
Lauren ten Hoor
ec9a29356f Merge pull request #36 from laurentenhoor/fix/27-persist-sessions-on-complete
fix: add defensive safeguards and documentation for session persistence
2026-02-10 10:52:49 +08:00
Lauren ten Hoor
d1a02d988d fix: add defensive safeguards and documentation for session persistence (#27)
- Add defensive verification in deactivateWorker to catch any accidental
  session clearing bugs
- Enhance documentation in activateWorker, deactivateWorker, and
  updateWorker to clearly explain session preservation behavior
- Add comprehensive example flow in activateWorker docs showing session
  reuse across multiple tasks and tiers
- Add test suite for session persistence (projects.test.ts) to prevent
  regression
- Add npm test script to run test suite

This ensures sessions persist per tier after task completion, enabling
session reuse across multiple tasks of the same tier for massive token
savings (~50K per reuse) and context preservation.

Fixes: Bug where sessions could theoretically be accidentally cleared
during worker state updates, though current code was already correct.
This adds defense-in-depth to make the invariant bulletproof.
2026-02-10 10:52:12 +08:00
Lauren ten Hoor
38ad3fe27f refactor: generalize channel type handling across various components 2026-02-10 09:56:17 +08:00
Lauren ten Hoor
cb0f628772 fix: strengthen 'no closing keywords' warning in DEV instructions (#24) (#34)
- Expanded DEFAULT_DEV_INSTRUCTIONS with more detailed context and explicit
  warning about not using 'Closes #X', 'Fixes #X', 'Resolves #X'
- Added 'Fixes issue #X' to the list of prohibited closing keywords
- Added new 'Worker Task Templates' section to AGENTS_MD_TEMPLATE with
  explicit CRITICAL warning about closing keywords in PR/MR descriptions
- Updated workflow steps to reinforce proper issue referencing:
  Use 'As described in issue #X' or 'Addresses issue #X' instead

This prevents GitHub from auto-closing issues when PRs merge, ensuring
DevClaw's task_complete validation and QA workflow are not bypassed.

As described in issue: #24
2026-02-10 09:36:51 +08:00
Lauren ten Hoor
a9e5b9ef3e feat: add task_update and task_comment tools (#33)
Closes #26

This PR adds two new DevClaw tools for better task lifecycle management:

- task_update: Change issue state programmatically without full pickup/complete flow
- task_comment: Add review comments or notes to issues with optional role attribution
2026-02-10 09:20:27 +08:00
Lauren ten Hoor
78bc95efb3 Merge pull request #32 from laurentenhoor/feature/24-remove-closes-keyword
fix: remove GitHub auto-closing keywords from worker templates (#24)
2026-02-10 09:03:42 +08:00
Lauren ten Hoor
4663fa6fec fix: remove GitHub auto-closing keywords from worker templates (#24)
- Added explicit warning to DEFAULT_DEV_INSTRUCTIONS
- Added warning to AGENTS_MD_TEMPLATE conventions section
- Workers instructed to use 'As described in issue #X' instead of 'Closes #X'
- Prevents GitHub/GitLab from auto-closing issues before QA validation
2026-02-10 09:03:19 +08:00
Lauren ten Hoor
31481d4ae2 Revert "fix: add explicit worker state update in task_pickup after dispatch (#23)"
This reverts commit d727a812e6.
2026-02-10 08:58:01 +08:00
Lauren ten Hoor
8c13173dc5 fix: add explicit worker state update in task_pickup after dispatch (#23) (#31)
Adds defense-in-depth by explicitly calling activateWorker() in task_pickup.ts
after dispatchTask() returns. This ensures the worker state (active, issueId,
model, sessionKey, startTime) is properly set in projects.json even if
dispatchTask's internal state update encounters issues.

The redundant update:
- Sets active=true, issueId, and model for both spawn and reuse cases
- Sets sessionKey and startTime only on new spawns (not on session reuse)
- Provides fallback if race conditions or I/O errors affect dispatch.ts

Fixes #23
2026-02-10 08:34:30 +08:00
Lauren ten Hoor
d727a812e6 fix: add explicit worker state update in task_pickup after dispatch (#23)
Adds defense-in-depth by explicitly calling activateWorker() in task_pickup.ts
after dispatchTask() returns. This ensures the worker state (active, issueId,
model, sessionKey, startTime) is properly set in projects.json even if
dispatchTask's internal state update encounters issues.

The redundant update:
- Sets active=true, issueId, and model for both spawn and reuse cases
- Sets sessionKey and startTime only on new spawns (not on session reuse)
- Provides fallback if race conditions or I/O errors affect dispatch.ts

Fixes #23
2026-02-10 08:34:03 +08:00
Lauren ten Hoor
6bc33b9d23 fix: use assert instead of expect in test file (#30) 2026-02-10 08:28:02 +08:00
Lauren ten Hoor
d8502362ec feat: enhance queue_status with execution-aware task sequencing (#29)
- Show plugin-level projectExecution setting in output
- Show project-level roleExecution for each project
- Sequential mode: single global task sequence across projects
- Parallel mode: per-project task tracks
- Proper handling of roleExecution within each project
- Priority ordering (To Improve > To Test > To Do)
- Visual distinction between active and upcoming tasks

Closes #21
2026-02-10 08:27:00 +08:00
Lauren ten Hoor
4d4bd34325 fix: re-throw error when state update fails after dispatch (#23) (#25)
When a worker session is successfully dispatched but activateWorker
fails to update projects.json, the error was being logged but not
re-thrown. This caused task_pickup to return success even though
the state wasn't updated, leading to task_complete failures later.

Now we re-throw the error after logging the warning, so the caller
knows the state update failed even though the session is running.

Fixes: #23
2026-02-10 01:30:45 +08:00