feat: enhance review process and role management
- Refactor reviewPass function to identify states with review checks instead of specific review types. - Introduce review policies (HUMAN, AGENT, AUTO) to control PR review processes based on developer levels. - Update projectTick to handle review policies and step routing labels for reviewers and testers. - Add detailed reviewer instructions to templates for clarity on review responsibilities. - Implement role:level label management, allowing dynamic creation of labels based on project configuration. - Enhance task_update tool to support state and level updates, ensuring at least one parameter is provided. - Update work_finish tool to include reviewer actions (approve, reject) in task completion. - Modify work_start tool to utilize role-level detection for better level assignment. - Add tests for new functionalities, including review routing and level detection from labels.
This commit is contained in:
Lauren ten Hoor
@@ -11,27 +11,30 @@ import { jsonResult } from "openclaw/plugin-sdk";
|
||||
import type { ToolContext } from "../types.js";
|
||||
import { log as auditLog } from "../audit.js";
|
||||
import type { StateLabel } from "../providers/provider.js";
|
||||
import { DEFAULT_WORKFLOW, getStateLabels } from "../workflow.js";
|
||||
import { DEFAULT_WORKFLOW, getStateLabels, findStateByLabel } from "../workflow.js";
|
||||
import { loadConfig } from "../config/index.js";
|
||||
import { requireWorkspaceDir, resolveProject, resolveProvider } from "../tool-helpers.js";
|
||||
|
||||
export function createTaskUpdateTool(api: OpenClawPluginApi) {
|
||||
return (ctx: ToolContext) => ({
|
||||
name: "task_update",
|
||||
label: "Task Update",
|
||||
description: `Change issue state programmatically. Use this when you need to update an issue's status without going through the full pickup/complete flow.
|
||||
description: `Change issue state and/or role:level assignment. Use this when you need to update an issue's status or override the assigned level.
|
||||
|
||||
Use cases:
|
||||
- Orchestrator or worker needs to change state manually
|
||||
- Manual status adjustments (e.g., Planning → To Do after approval)
|
||||
- Override the assigned level (e.g., escalate to senior for human review)
|
||||
- Force human review via level change
|
||||
- Failed auto-transitions that need correction
|
||||
- Bulk state changes
|
||||
|
||||
Examples:
|
||||
- Simple: { projectGroupId: "-123456789", issueId: 42, state: "To Do" }
|
||||
- With reason: { projectGroupId: "-123456789", issueId: 42, state: "To Do", reason: "Approved for development" }`,
|
||||
- State only: { projectGroupId: "-123456789", issueId: 42, state: "To Do" }
|
||||
- Level only: { projectGroupId: "-123456789", issueId: 42, level: "senior" }
|
||||
- Both: { projectGroupId: "-123456789", issueId: 42, state: "To Do", level: "senior", reason: "Escalating to senior" }`,
|
||||
parameters: {
|
||||
type: "object",
|
||||
required: ["projectGroupId", "issueId", "state"],
|
||||
required: ["projectGroupId", "issueId"],
|
||||
properties: {
|
||||
projectGroupId: {
|
||||
type: "string",
|
||||
@@ -46,9 +49,13 @@ Examples:
|
||||
enum: getStateLabels(DEFAULT_WORKFLOW),
|
||||
description: `New state for the issue. One of: ${getStateLabels(DEFAULT_WORKFLOW).join(", ")}`,
|
||||
},
|
||||
level: {
|
||||
type: "string",
|
||||
description: "Override the role:level assignment (e.g., 'senior', 'junior'). Detects role from current state label.",
|
||||
},
|
||||
reason: {
|
||||
type: "string",
|
||||
description: "Optional audit log reason for the state change",
|
||||
description: "Optional audit log reason for the change",
|
||||
},
|
||||
},
|
||||
},
|
||||
@@ -56,41 +63,86 @@ Examples:
|
||||
async execute(_id: string, params: Record<string, unknown>) {
|
||||
const groupId = params.projectGroupId as string;
|
||||
const issueId = params.issueId as number;
|
||||
const newState = params.state as StateLabel;
|
||||
const newState = (params.state as StateLabel) ?? undefined;
|
||||
const newLevel = (params.level as string) ?? undefined;
|
||||
const reason = (params.reason as string) ?? undefined;
|
||||
const workspaceDir = requireWorkspaceDir(ctx);
|
||||
|
||||
if (!newState && !newLevel) {
|
||||
throw new Error("At least one of 'state' or 'level' must be provided.");
|
||||
}
|
||||
|
||||
const { project } = await resolveProject(workspaceDir, groupId);
|
||||
const { provider, type: providerType } = await resolveProvider(project);
|
||||
|
||||
const issue = await provider.getIssue(issueId);
|
||||
const currentState = provider.getCurrentStateLabel(issue);
|
||||
if (!currentState) {
|
||||
throw new Error(`Issue #${issueId} has no recognized state label. Cannot perform transition.`);
|
||||
throw new Error(`Issue #${issueId} has no recognized state label. Cannot perform update.`);
|
||||
}
|
||||
|
||||
if (currentState === newState) {
|
||||
return jsonResult({
|
||||
success: true, issueId, state: newState, changed: false,
|
||||
message: `Issue #${issueId} is already in state "${newState}".`,
|
||||
project: project.name, provider: providerType,
|
||||
});
|
||||
let stateChanged = false;
|
||||
let levelChanged = false;
|
||||
let fromLevel: string | undefined;
|
||||
|
||||
// Handle state transition
|
||||
if (newState && currentState !== newState) {
|
||||
await provider.transitionLabel(issueId, currentState, newState);
|
||||
stateChanged = true;
|
||||
}
|
||||
|
||||
await provider.transitionLabel(issueId, currentState, newState);
|
||||
// Handle level override
|
||||
if (newLevel) {
|
||||
// Detect role from current (or new) state label
|
||||
const effectiveState = newState ?? currentState;
|
||||
const workflow = (await loadConfig(workspaceDir, project.name)).workflow;
|
||||
const stateConfig = findStateByLabel(workflow, effectiveState);
|
||||
const role = stateConfig?.role;
|
||||
if (!role) {
|
||||
throw new Error(`Cannot determine role from state "${effectiveState}". Level can only be set on role-assigned states.`);
|
||||
}
|
||||
|
||||
// Validate level exists for role
|
||||
const resolvedConfig = await loadConfig(workspaceDir, project.name);
|
||||
const roleConfig = resolvedConfig.roles[role];
|
||||
if (!roleConfig || !roleConfig.levels.includes(newLevel)) {
|
||||
throw new Error(`Invalid level "${newLevel}" for role "${role}". Valid levels: ${roleConfig?.levels.join(", ") ?? "none"}`);
|
||||
}
|
||||
|
||||
// Remove old role:* labels, add new role:level
|
||||
const oldRoleLabels = issue.labels.filter((l) => l.startsWith(`${role}:`));
|
||||
fromLevel = oldRoleLabels[0]?.split(":")[1];
|
||||
if (oldRoleLabels.length > 0) {
|
||||
await provider.removeLabels(issueId, oldRoleLabels);
|
||||
}
|
||||
await provider.addLabel(issueId, `${role}:${newLevel}`);
|
||||
levelChanged = fromLevel !== newLevel;
|
||||
}
|
||||
|
||||
// Audit
|
||||
await auditLog(workspaceDir, "task_update", {
|
||||
project: project.name, groupId, issueId,
|
||||
fromState: currentState, toState: newState,
|
||||
...(stateChanged ? { fromState: currentState, toState: newState } : {}),
|
||||
...(levelChanged ? { fromLevel: fromLevel ?? null, toLevel: newLevel } : {}),
|
||||
reason: reason ?? null, provider: providerType,
|
||||
});
|
||||
|
||||
// Build announcement
|
||||
const parts: string[] = [];
|
||||
if (stateChanged) parts.push(`"${currentState}" → "${newState}"`);
|
||||
if (levelChanged) parts.push(`level: ${fromLevel ?? "none"} → ${newLevel}`);
|
||||
const changeDesc = parts.join(", ");
|
||||
|
||||
return jsonResult({
|
||||
success: true, issueId, issueTitle: issue.title,
|
||||
state: newState, changed: true,
|
||||
labelTransition: `${currentState} → ${newState}`,
|
||||
...(newState ? { state: newState } : {}),
|
||||
...(newLevel ? { level: newLevel } : {}),
|
||||
changed: stateChanged || levelChanged,
|
||||
...(stateChanged ? { labelTransition: `${currentState} → ${newState}` } : {}),
|
||||
project: project.name, provider: providerType,
|
||||
announcement: `🔄 Updated #${issueId}: "${currentState}" → "${newState}"${reason ? ` (${reason})` : ""}`,
|
||||
announcement: stateChanged || levelChanged
|
||||
? `🔄 Updated #${issueId}: ${changeDesc}${reason ? ` (${reason})` : ""}`
|
||||
: `Issue #${issueId} is already in the requested state.`,
|
||||
});
|
||||
},
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user